View Single Post
06-05-2008, 12:38 AM
#13
rochow is offline rochow
rochow's Avatar
Status: Member
Join date: Oct 2006
Location: Australia
Expertise:
Software:
 
Posts: 297
iTrader: 4 / 100%
 

rochow is on a distinguished road

Send a message via MSN to rochow Send a message via Skype™ to rochow

  Old

Originally Posted by Andrew R View Post
I'll pick the rest out later but this if the first one I came across.

Note the empty span tags in the navigation: http://www.matthewrochow.com/projects/driven/

Also on that same page, search for these:
<a href="#" class="button"></a>
<li id="m5"></li>
<div class="abox-bt"></div>

You use some of those multiple times.

etc... do you want me to continue onto your other work?

Also, as for unnecessary ones, you could've easily gotten rid of many of your wrapping/content divs. You don't need a header container, you only need one to wrap around the entire content (the top image could be the background of the navigation, the bottom image could be on the footer, main background on that one div), and you don't need so many inner ones.
I didn't actually do all of that, I just tidied it up a bit. I was questioning whether to put it in or not (as it's not entirely my own), but it makes the number of items nice and even.

Pick on some newer ones please.

I was looking through yours. Granted, I don't want to pick on your old work - as time goes on better ways of doing things are learnt. I found quite a few things in this that could be improved.