|
|
|
|
Thread title: XHTML This - Quality Coding |
|
|
Page 2 of 9 |
< |
1 |
2 |
3 |
4 |
5 |
6 |
> |
|
|
|
Thread tools
Search this thread
Display Modes
|
|
12-17-2006, 12:04 AM
|
#11
|
Status: Request a custom title
Join date: Dec 2005
Location: Staffordshire, UK
Expertise: Design
Software: Photoshop
Posts: 2,410
|
Got any examples of vB coding? Turnaround time for skinning?
|
|
12-17-2006, 12:08 AM
|
#12
|
Status: Waving
Join date: Aug 2005
Location:
Expertise:
Software:
Posts: 2,694
|
I'm setting up my vB and all right now, a few of the 500 Errors, are because it's not .html but /...
Cpr ill make sure I get my vB stuff up!
|
|
12-17-2006, 12:08 AM
|
#13
|
Status: Pastafarian
Join date: May 2006
Location: Duct Taped to your Ceiling
Expertise:
Software:
Posts: 3,440
|
You are offering coding services, right? Seems you might want to work on your code first...
The site is coded in Transitional? What's that about?
You are using dated (and unneeded) techniques such as
Code:
<div class="badge"> </div>
You have three 500 errors.
You have a class applied <li class=""> applied to each of your nav links. That is a poor (read incorrect) method of styling.
You have unnecessary nesting of ID tags:
Code:
<div id="tabs">
<ul id="tab">
<li>etc etc</li>
</ul>
</div>
Before you offer your services, you might consider picking up CSS Mastery from Amazon, it's only like 30$.
The design is fine I suppose, but more fitted to a blog than a services site.
Just some things you might want to work on before opening up. Congrats on a new site though.
|
|
12-17-2006, 12:13 AM
|
#14
|
Status: I love this place
Join date: Apr 2006
Location: China
Expertise:
Software:
Posts: 507
|
Wow, nice best of luck with this project
|
|
12-17-2006, 12:27 AM
|
#15
|
Status: Request a custom title
Join date: Dec 2005
Location: Colchester, UK
Expertise:
Software:
Posts: 4,625
|
It's looking very nice!
You may want to rethink some of your policies though.
vBulletin - 150$
With this software, you will recieve a XML file, along with the images, so your site is ready to go the instant I send it to you. All templates will be edited, not just 3 like the other guys.
|
I can imagine you will regret that when you get a particularly tricky skin.
Also, you might want to work on some of the copywriting; Particularly on the 'About' page.
|
|
12-17-2006, 12:39 AM
|
#16
|
Status: Request a custom title
Join date: Dec 2005
Location: Arizona
Expertise:
Software:
Posts: 5,200
|
Like I said on MSN, I love it.
|
|
12-17-2006, 12:39 AM
|
#17
|
Status: Waving
Join date: Aug 2005
Location:
Expertise:
Software:
Posts: 2,694
|
Originally Posted by Blue Ire
You are offering coding services, right? Seems you might want to work on your code first...
The site is coded in Transitional? What's that about?
You are using dated (and unneeded) techniques such as
Code:
<div class="badge"> </div>
You have three 500 errors.
You have a class applied <li class=""> applied to each of your nav links. That is a poor (read incorrect) method of styling.
You have unnecessary nesting of ID tags:
Code:
<div id="tabs">
<ul id="tab">
<li>etc etc</li>
</ul>
</div>
Before you offer your services, you might consider picking up CSS Mastery from Amazon, it's only like 30$.
The design is fine I suppose, but more fitted to a blog than a services site.
Just some things you might want to work on before opening up. Congrats on a new site though.
|
Not trying to pick a fight, but what does it matter if I use a inside the div? If I didn't do so, it wouldn't be valid anyways.
And those 500 errors are gone, I forgot to take off the / and put .html.
I don't see how thats a poor method of styling a navigation in my case.
How else would you be able to do it? Inform me please. Look at any other CSS Website that uses Li's for navigation.
Sites: http://cssvault.com/ http://www.terrabaltica.lv/en http://www.simplebits.com/
If such sites as those use the method I use, we must all be wrong huh?
The tabs, has 2 parts, a shadow with corners, and a purple part, that's why I used a div along with a ul. I could just put it in a background in a UL, but it wouldn't be able to use the trick im using for the content.
Thanks for your ideas Blue Ire, not trying to sound mean. But if you code differently, go ahead do that. But I use different methods as you.
Thanks Indy for the advice.
|
|
12-17-2006, 02:44 AM
|
#18
|
Status: Pastafarian
Join date: May 2006
Location: Duct Taped to your Ceiling
Expertise:
Software:
Posts: 3,440
|
Code:
If such sites as those use the method I use, we must all be wrong huh?
I do believe you've made my point for me. CSSvault isn't even valid... but hey, they must be right. Lets all follow them, and stop writing valid code.
Wait, what?... Perhaps doing things just because others do them isn't the best plan.
It's just like everything else; there is common usage and correct usage. I was merely suggesting you look into correct usage. If that's too much hassle, no big deal - I just figured since you are selling code services, you would want your site to be perfect.
edit.
Just so we are clear I'm not implying that I write perfect code - I don't. I'm making suggestions that I think can ultimately benefit Garrett both monetarily and intellectually.
|
|
12-17-2006, 03:47 AM
|
#19
|
Status: Waving
Join date: Aug 2005
Location:
Expertise:
Software:
Posts: 2,694
|
Originally Posted by Blue Ire
Code:
If such sites as those use the method I use, we must all be wrong huh?
I do believe you've made my point for me. CSSvault isn't even valid... but hey, they must be right. Lets all follow them, and stop writing valid code.
Wait, what?... Perhaps doing things just because others do them isn't the best plan.
It's just like everything else; there is common usage and correct usage. I was merely suggesting you look into correct usage. If that's too much hassle, no big deal - I just figured since you are selling code services, you would want your site to be perfect.
edit.
Just so we are clear I'm not implying that I write perfect code - I don't. I'm making suggestions that I think can ultimately benefit Garrett both monetarily and intellectually.
|
Why don't you inform me what the "correct" way to do it is then Blue, actually don't, I didn't intend this thread to go about how I do things. If you want to comment how I do things, send me a PM.
I didn't expect a staff member here to do what they did. And i'm quite sure it's because your either jealous or something.
And I didn't imply that I shouldn't write valid code, so don't go that route.
Send me a PM if you want to comment how I code.
|
|
12-17-2006, 03:52 AM
|
#20
|
Status: I love this place
Join date: Aug 2006
Location: Wenatchee, Washington
Expertise:
Software:
Posts: 662
|
Hey garrett, i've got a question for you...
If you didn't want critique, why post it in the gallery showcase?
Read the forum description; "Post your latest creations in here for review by the community."
i.e., comments from the community. Honestly, saying he's jealous of you because he corrected your mistakes is pretty damn immature.
|
|
|
|
|
|
|
Page 2 of 9 |
< |
1 |
2 |
3 |
4 |
5 |
6 |
> |
|
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
|
|
|
|